Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invisible holograms with 1.7 clients #558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blastyman
Copy link

@blastyman blastyman commented Dec 26, 2024

before this fix:
image
after this fix:
image

Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct, when comparing both game source codes the type definitely has changed. Are there any errors or is the server sending per version data to the player?

@blastyman
Copy link
Author

Yes, the server is sending per version data to the player, since armor stands do not exist on 1.7 so we have to send 1.7 specific holograms (aka horse with negative age)

@FlorianMichael
Copy link
Member

Then the server is sending bad data which not would on a native client as well. Assuming the server is running 1.8, why does it even need per version data? ViaRewind should take care of entity data rewriting and emulate armor stands send by the server.

@blastyman
Copy link
Author

Because ViaRewind doesn't take proper care of it, it's broken. Otherwise we wouldn't do it

@FlorianMichael
Copy link
Member

Then it would make more sense to report it properly, but anyway you are sending wrong data to the client. This needs fixing in your server plugins instead of ViaRewind.

@blastyman
Copy link
Author

blastyman commented Dec 29, 2024

image
image
image

The problem still persists, ViaRewind doesn't work as intended. I'm not going to fix it myself or hire a developer to do it as it's not my plugin. My commit fixes the issue immediately without breaking anything. Whether or not you want to merge this is up to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants